Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): fix builder state machine replacement tracking #738

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(builder): fix builder state machine replacement tracking #738

merged 1 commit into from
Jun 25, 2024

Conversation

dancoombs
Copy link
Collaborator

@dancoombs dancoombs commented Jun 24, 2024 •
edited
Loading

Implement a better tracking mechanism for state machine replacement underpriced tracking.

TODO:

  • Unit tests for new tracking
  • Update docs with state machine diagram and description

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.98438% with 105 lines in your changes missing coverage. Please review.

Project coverage is 57.27%. Comparing base (e6c9f15) to head (7c9c85b).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/pool/src/mempool/pool.rs 95.79% <94.11%> (-0.07%) ⬇️
crates/builder/src/task.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
crates/builder/src/bundle_proposer.rs 90.29% <75.00%> (-0.08%) ⬇️
crates/builder/src/transaction_tracker.rs 79.17% <66.66%> (-2.00%) ⬇️
crates/builder/src/bundle_sender.rs 69.97% <52.86%> (-2.83%) ⬇️
Flag Coverage Δ
unit-tests 57.27% <58.98%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 59.16% <57.44%> (-0.38%) ⬇️
dev 0.00% <ø> (ø)
pool 64.95% <94.11%> (-0.07%) ⬇️
provider 16.10% <ø> (ø)
rpc 25.64% <ø> (ø)
sim 78.25% <ø> (ø)
tasks ∅ <ø> (∅)
types 66.68% <ø> (ø)
utils 18.28% <ø> (ø)

0xfourzerofour
0xfourzerofour approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just a nit

crates/builder/src/task.rs Outdated Show resolved Hide resolved
crates/builder/src/transaction_tracker.rs Show resolved Hide resolved
@dancoombs dancoombs force-pushed the danc/builder-state-fixes branch 2 times, most recently from 6b8d23f to ddb7623 Compare June 25, 2024 15:16
@dancoombs dancoombs merged commit ac74140 into feat/v0.3 Jun 25, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/builder-state-fixes branch June 25, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @0xfourzerofour